-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Elixir Dynamic Supervisor #62
Add Elixir Dynamic Supervisor #62
Conversation
Hi @QuantamHD, I don't have time to check this in detail today, but I do think we need to consider how to handle the DynamicSupervisor. IMO it should go something like this:
This is going to make it easier for me to review this PR, and also make it easier in the future to keep us up to date with the Elixir DynamicSupervisor. Aside from that, thanks for the effort and I'll make it a priority to give you more in depth feedback soon. Derek |
clean up
f8221c3
to
8127484
Compare
Okay only thing I changed here was the name of the module just because if I didn't the modules would conflict and not compile |
I needed to update the elixir version to 1.7 as the current dynamic supervisor uses the STACKTRACE construct only available in 1.7 |
Hi, I noticed you had taken the Cheers |
I was wondering if we could create a branch off master to merge this to so that any new changes would be a little easier to see? |
Sounds like a good idea. I've created a branch for that, I'll merge this PR in that branch so you can continue with a fresh PR. |
No description provided.