Change default tape mode #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The macro was capturing the exceptions and causing a failing test to pass when the exception was happening before the asserts statements.
|
Thanks for PR! I think it might make sense to configure this using application configuration. So that in What do you think? |
caioceccon
force-pushed
the
feature/change-default-tape-mode
branch
2 times, most recently
from
1a8283f
to
58781d9
Compare
caioceccon
force-pushed
the
feature/change-default-tape-mode
branch
from
58781d9
to
d68efdc
Compare
|
Thanks @caioceccon , looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to change the default tape mode be calling
Walkman.set_global_default(true).I have initially thought about doing something like:
@spec set_default_tape_mode(mode :: :global | :local) :: :okBut because it would be different from the options used by use_tape macro which allow to pass the options global: true, or false I have implemented as in:
@spec set_global_default(default_value :: true | false) :: :okPlease let me know if is there preference for one over the other. I believe that tape mode or type with possible values as :global and :local would make more sense but then would be better to make the macro use_tape consistent and use the same possible name and value for accepted options.