Upgrade tests to run on Elixir 1.12 #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Some fixtures had to be re-recorded. To achieve this I had to temporarily edit the relevant tests to ensure there were no errors, so that the recording was saved. * I got warnings when the Walkman.def_stub/2 calls were inside the test block. Moving them into the module solved the problem.
|
Context: I tried to run the tests but I needed to be running OTP 22. I was unable to compile OTP 22 in my environment. Therefore I worked on updating the tests to run on a more recent release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixtures had to be re-recorded. To achieve this I had to
temporarily edit the relevant tests to ensure there were no errors, so
that the recording was saved.
I got warnings when the Walkman.def_stub/2 calls were inside the test
block. Moving them into the module solved the problem.