Handle new _serialize === true functionality #11
Conversation
| } | ||
| $this->Controller->set('_serialize', $serializeKeys); |
There was a problem hiding this comment.
It would be cleaner and easier to just return early
if ($this->Controller->viewVars['_serialize'] === true) {
return;
}
There was a problem hiding this comment.
I tend to agree, but so many people seem obsessed with having only a single return point from functions. I'll make the change and submit a new PR?
There was a problem hiding this comment.
Having return early is one of the most useful code practices. I dont know any sane person who would argue against that.
There was a problem hiding this comment.
No need, you can just update this PR with a 2nd commit - by pushing to the same branch.
|
See, so much cleaner :) Beautiful, thx! |
|
PS: Tests are failing, you need an additional |
|
In the interests of reducing duplicate code, I'm tempted to put the new block inside the existing |
|
return early still trumps it IMO as more levels of nesting is always worse. |
Handle new _serialize === true functionality
Resolution for issue #10