add generic type hint + helpful exception for ServicesTrait #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #415 +/- ##
============================================
- Coverage 70.94% 70.86% -0.08%
- Complexity 698 699 +1
============================================
Files 37 37
Lines 2433 2437 +4
============================================
+ Hits 1726 1727 +1
- Misses 707 710 +3 ☔ View full report in Codecov by Sentry. |
dereuromark
reviewed
Mar 9, 2024
|
Updated the type variable as |
|
We will have to backport this to 5.x branch for Patch release |
|
Backport done in 0ff769f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #414