Feh tries to read .tar.bz2 files and it takes a looooong time

[ghost]

Steps to reproduce:

1. Create a big .tar.bz archive in a directory with images:

$ dd if=/dev/urandom of=data.bin bs=30M count=10
$ tar cf data.tar data.bin
$ bzip2 -9 data.tar

2. Then start feh . and use space to cycle through all the images.

It takes a long time to skip this data.tar.bz2 file (why does feh even try to load it?)

Something like this happens with .mkv files and probably others.

[derf]

feh relies on Imlib2 to load images.

Imlib2 contains a bzip2 loader, allowing it to seamlessly load images which were compressed using bzip2. Unfortunately, it decompresses the entire file before checking its header for the appropriate magic bytes, leading to the issue you observe.

There isn't much feh can do about this, sorry. Could you address this issue to the Imlib2 developers?

[Ferada]

Pretty sure it's not even checking magic bytes, only the file ending. I'm trying to get this patch in to fix this.

[Ferada]

Was merged, together with a fix for .gz too; this issue should be fixed with that.

[ghost]

I'll try to apply the patch and test it.

[ghost]

The above link (https://phab.enlightenment.org/D10398) doesn't work now (Unable to connect to MySQL!), and the latest commit to the master branch was in July.

[Ferada]

@opennota that's hopefully a temporary problem; try fetching from https://git.enlightenment.org/legacy/imlib2.git, the last commit on master there was Tue Oct 15 20:08:43 2019 +0200 which now includes the fixes.

[ghost]

Works like a charm, thank you! I'll close the issue.