Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FGR: account for cumulative delays ≥20 minutes #116

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

deingithub
Copy link
Contributor

Because metronom's reliability is approaching an area where actually getting compensation for a 49 euro ticket starts becoming feasible month-for-month by me, i've decided to implement #73:

in the FGR page there's now an explanation and link to the new cumulative delays subpage:
Screenshot 2024-02-09 at 19-56-47 travelynx


there's a progress bar on how much delays you have to "earn" to get at least some of your money back, and a list of offending trains with FGR form download links:
Screenshot 2024-02-09 at 20-02-53 travelynx Zeitkarten-Fahrgastrechte
Screenshot 2024-02-09 at 20-03-32 travelynx Zeitkarten-Fahrgastrechte


you can select which ticket (for which timeframe) you're using, which will change the projected reimbursement. selecting a regional ticket excludes long-distance trains.
Screenshot from 2024-02-09 20-03-49

Screenshot 2024-02-09 at 20-07-01 travelynx Zeitkarten-Fahrgastrechte


this is my first contribution where i actually touched the perl code a bit. i do not know perl! the code might be awful and not idiomatic. i apologize in advance for that specifically.

have a nice weekend! 🧡

@deingithub
Copy link
Contributor Author

deingithub commented Feb 14, 2024

i noticed that it didn't actually account for train cancellations followed by a substitute connection yet, so i added that as well. it gets displayed like this:
Screenshot 2024-02-14 at 19-17-45 travelynx Fahrgastrechte Zeitkarten

this PR doesn't touch the normal FGR view and all changes are exclusively in the cumulative view but i can convert the normal page to the departureboard style list too at a later point if so desired :)

* add a tiny arrow to better communicate travel direction
* the destination bubble is now a "check", as in check-out
* the train origin is now an empty bublbe
* cancelled train stops are set in italics
@deingithub
Copy link
Contributor Author

ok as what i hope is the final touch this time, the view now also includes missed connections like the regular FGR page:
Screenshot from 2024-02-17 12-32-04


i've also added some visual restyling of the route history that hopefully better indicates that the direction of travel is "upwards":
Screenshot 2024-02-17 at 14-03-28 travelynx Fahrgastrechte Zeitkarten
Screenshot 2024-02-17 at 14-03-50 travelynx Fahrgastrechte Zeitkarten
Screenshot 2024-02-17 at 14-03-12 travelynx Fahrgastrechte Zeitkarten

i applied the same formatting to the /cancelled page, which now looked a bit weird because the list of cancelled trains had the "success" checkmark at the top.

@deingithub
Copy link
Contributor Author

Hey,
I hope this doesn't come across as pushy, but I wanted to know if there's some timeframe for a review on this and the two smaller PRs — you mentioned #122 is on hold for now, that's totally fair of course. There's more stuff I'd like to start working on, buuut I also don't want to make the pile of PRs to review even bigger. I understand that there's probably a lot on your plate in general currently, just a "haven't forgotten about this" or some pointers where I could help with making review easier would be nice already 😅
Thanks!

@derf
Copy link
Owner

derf commented Apr 15, 2024

I have seen the PR, appreciate it, and will not provide a time frame. It's fairly certain that I'll review and merge it eventually.

travelynx is a hobby project which I work on whenever and wherever I feel like, and I find it healthy to take that hobby aspect seriously. Sorry about that ;)

@deingithub
Copy link
Contributor Author

deingithub commented Apr 15, 2024

Not setting a timeframe is fully okay of course. Appreciate hearing back from you anyway, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants