Skip to content

Commit

Permalink
mtd: cfi_cmdset_0002: don't free cfi->cfiq in error path of cfi_amdst…
Browse files Browse the repository at this point in the history
…d_setup()

Else there may be a double-free problem, because cfi->cfiq will
be freed by mtd_do_chip_probe() if both the two invocations of
check_cmd_set() return failure.

Signed-off-by: Hou Tao <houtao1@huawei.com>
Reviewed-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
  • Loading branch information
Hou Tao authored and r-vignesh committed Nov 9, 2019
1 parent ea4f513 commit 03976af
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/mtd/chips/cfi_cmdset_0002.c
Original file line number Diff line number Diff line change
Expand Up @@ -785,7 +785,6 @@ static struct mtd_info *cfi_amdstd_setup(struct mtd_info *mtd)
kfree(mtd->eraseregions);
kfree(mtd);
kfree(cfi->cmdset_priv);
kfree(cfi->cfiq);
return NULL;
}

Expand Down

0 comments on commit 03976af

Please sign in to comment.