Skip to content

Commit

Permalink
btrfs: Remove extra parentheses from condition in copy_items()
Browse files Browse the repository at this point in the history
commit 0dde10b upstream.

There is no need for the extra pair of parentheses, remove it. This
fixes the following warning when building with clang:

fs/btrfs/tree-log.c:3694:10: warning: equality comparison with extraneous
  parentheses [-Wparentheses-equality]
                if ((i == (nr - 1)))
                     ~~^~~~~~~~~~~

Also remove the unnecessary parentheses around the substraction.

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: David Sterba <dsterba@suse.com>
Cc: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Matthias Kaehlcke authored and gregkh committed Apr 8, 2018
1 parent 471d4a4 commit e7f42b0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/btrfs/tree-log.c
Original file line number Diff line number Diff line change
Expand Up @@ -3664,7 +3664,7 @@ static noinline int copy_items(struct btrfs_trans_handle *trans,

src_offset = btrfs_item_ptr_offset(src, start_slot + i);

if ((i == (nr - 1)))
if (i == nr - 1)
last_key = ins_keys[i];

if (ins_keys[i].type == BTRFS_INODE_ITEM_KEY) {
Expand Down

0 comments on commit e7f42b0

Please sign in to comment.