Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issues with Inscription #34

Closed
Dece11 opened this issue Jan 17, 2023 · 1 comment
Closed

Some issues with Inscription #34

Dece11 opened this issue Jan 17, 2023 · 1 comment

Comments

@Dece11
Copy link

Dece11 commented Jan 17, 2023

Hey,
Love your work, the addon is great, ive found a few issues though

Craftsim does not correctly calculate Profit for all Missives in Inscription (seems like some issue with quality?)
https://gyazo.com/985db9a1e6712f2219ea371ea500460f

Also with Combatant Gear (Specifically Crimson Combatant's Emblem)

It does not appear to be updating pricing data when using Auctioneer as source, idk if this is just me or something more?
https://gyazo.com/97b1f5ef25a6f032e16853f94d2669eb

Thanks

@derfloh205
Copy link
Owner

derfloh205 commented Jan 18, 2023

Missives:
Thank you for reporting that, I fetched the itemIDs for the different qualities from the UI until now, but it seems that sometimes the order blizzard has the item ids in the quality list ist just plain wrong.
I reimplemented this to, similar to gear, fetch the result items from the ingame api now and this is fixed now with 3.2+

Combatant Gear:
I dont really get whats the issue here? The quality 5 profit and the average profit resulting from it seems to be in line with the auctionator profit shown.
If you mean that after hitting search its not updating immediately, this is due to CraftSim not yet getting triggered by this search. You have to click to another recipe and back to refresh it (Or change any materials, or switch to sim mode and back)

If this is not what you ment, feel free to open another issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants