Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can still win the game if wrong flags have been placed #1

Closed
hammer065 opened this issue Jul 3, 2017 · 6 comments · Fixed by #4
Closed

You can still win the game if wrong flags have been placed #1

hammer065 opened this issue Jul 3, 2017 · 6 comments · Fixed by #4

Comments

@hammer065
Copy link

If you place more flags than there are mines, its still possible to win the game.
Here an extreme example of it:
https://asciinema.org/a/bqGkvtZjIztnQmpd3cLSgAv5D

@derhuerst
Copy link
Owner

What is the expected behaviour?

@derhuerst
Copy link
Owner

Actually, right now, you win as soon as you have flagged all bombs.

@hammer065
Copy link
Author

The expected behaviour is, that if you place more flags than there are bombs, that you won't win the game.
Means the player only should place flags on top of bombs and not on empty fields.

@derhuerst
Copy link
Owner

Sounds reasonable. 😛 Would you mind making a PR?

@LRFLEW
Copy link
Contributor

LRFLEW commented Oct 4, 2017

For the record, the Minesweeper game included in Windows set the win condition to be when all of the non-mine locations have been revealed. You can set flags on all of the mines exactly, but it doesn't count as a win until all of the other spaces have been revealed.

@derhuerst
Copy link
Owner

Okay, so the correct win condition would be "all bombs flagged and all empty spaces revealed". @LRFLEW Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants