-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
You can still win the game if wrong flags have been placed #1
Comments
What is the expected behaviour? |
Actually, right now, you win as soon as you have flagged all bombs. |
The expected behaviour is, that if you place more flags than there are bombs, that you won't win the game. |
Sounds reasonable. 😛 Would you mind making a PR? |
For the record, the Minesweeper game included in Windows set the win condition to be when all of the non-mine locations have been revealed. You can set flags on all of the mines exactly, but it doesn't count as a win until all of the other spaces have been revealed. |
Okay, so the correct win condition would be "all bombs flagged and all empty spaces revealed". @LRFLEW Thanks for the PR! |
If you place more flags than there are mines, its still possible to win the game.
Here an extreme example of it:
https://asciinema.org/a/bqGkvtZjIztnQmpd3cLSgAv5D
The text was updated successfully, but these errors were encountered: