Add Cloudera repo installation #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix gpgcheck value in repo.pp
| '6': { | ||
| exec{ 'retrieve_clouderakey': | ||
| command => "/usr/bin/curl -q http://archive.cloudera.com/cdh${cdhver}/redhat/6/${::hardwaremodel}/cdh/RPM-GPG-KEY-cloudera -o /etc/pki/rpm-gpg/RPM-GPG-KEY-cloudera", | ||
| creates => '/etc/pki/rpm-gpg/RPM-GPG-KEY-cloudera', |
There was a problem hiding this comment.
do we really need this, when GPG key URI is defined on line 43?
|
Yeah, the GPG download wasn't necessary, so I removed it in my lastest commit. Let me know if you have any other suggestions. |
|
Great, looks good. Thanks a lot! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-zookeeper
that referenced
this pull request
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the ability to install the Cloudera Yum repo to completely automat the retrieval and installation of zookeeper packages. I couldn't find a better way to get the GPG key than using an "exec" with curl, but hopefully that isn't too big of an issue.