Make service run even if bin/zkEnv.sh does not exist #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do not understand why Travis reports failures, should I branch from other than master? |
|
No, it looks like failures are caused by 3rd party test dependencies, that dropped Ruby 2.0 support. Don't worry about that. |
|
Ok, looks good. Thanks! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-zookeeper
that referenced
this pull request
Sep 7, 2020
Make service run even if bin/zkEnv.sh does not exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some deployment of Zookeeper do not contain bin/zkEnv.sh and this make the service to fail when starting it.
The proposed change just check if file exist before executing it.