Skip to content

Commit

Permalink
Remove unnecessary SKIPIFs from ReadPreference tests
Browse files Browse the repository at this point in the history
  • Loading branch information
jmikola committed Sep 19, 2016
1 parent 236e9bd commit d9b6613
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 18 deletions.
3 changes: 0 additions & 3 deletions tests/readPreference/readpreference-ctor-001.phpt
@@ -1,10 +1,7 @@
--TEST--
MongoDB\Driver\ReadPreference construction
--SKIPIF--
<?php require __DIR__ . "/../utils/basic-skipif.inc"?>
--FILE--
<?php
require_once __DIR__ . "/../utils/basic.inc";

var_dump(new MongoDB\Driver\ReadPreference(MongoDB\Driver\ReadPreference::RP_PRIMARY));
var_dump(new MongoDB\Driver\ReadPreference(MongoDB\Driver\ReadPreference::RP_SECONDARY, array(array("tag" => "one"))));
Expand Down
5 changes: 2 additions & 3 deletions tests/readPreference/readpreference-ctor_error-001.phpt
@@ -1,10 +1,9 @@
--TEST--
MongoDB\Driver\ReadPreference construction (invalid mode)
--SKIPIF--
<?php require __DIR__ . "/../utils/basic-skipif.inc"?>
--FILE--
<?php
require_once __DIR__ . "/../utils/basic.inc";

require_once __DIR__ . '/../utils/tools.php';

echo throws(function() {
new MongoDB\Driver\ReadPreference(42);
Expand Down
5 changes: 2 additions & 3 deletions tests/readPreference/readpreference-ctor_error-002.phpt
@@ -1,10 +1,9 @@
--TEST--
MongoDB\Driver\ReadPreference construction (invalid tagSets)
--SKIPIF--
<?php require __DIR__ . "/../utils/basic-skipif.inc"?>
--FILE--
<?php
require_once __DIR__ . "/../utils/basic.inc";

require_once __DIR__ . '/../utils/tools.php';

echo throws(function() {
new MongoDB\Driver\ReadPreference(MongoDB\Driver\ReadPreference::RP_PRIMARY, [['tag' => 'one']]);
Expand Down
3 changes: 0 additions & 3 deletions tests/readPreference/readpreference-getMode-001.phpt
@@ -1,10 +1,7 @@
--TEST--
MongoDB\Driver\ReadPreference::getMode()
--SKIPIF--
<?php require __DIR__ . "/../utils/basic-skipif.inc"?>
--FILE--
<?php
require_once __DIR__ . "/../utils/basic.inc";

$tests = array(
MongoDB\Driver\ReadPreference::RP_PRIMARY,
Expand Down
3 changes: 0 additions & 3 deletions tests/readPreference/readpreference-getTagSets-001.phpt
@@ -1,10 +1,7 @@
--TEST--
MongoDB\Driver\ReadPreference::getTagSets()
--SKIPIF--
<?php require __DIR__ . "/../utils/basic-skipif.inc"?>
--FILE--
<?php
require_once __DIR__ . "/../utils/basic.inc";

$tests = array(
null,
Expand Down
3 changes: 0 additions & 3 deletions tests/readPreference/readpreference_error-001.phpt
@@ -1,10 +1,7 @@
--TEST--
MongoDB\Driver\ReadPreference cannot be extended
--SKIPIF--
<?php require __DIR__ . "/../utils/basic-skipif.inc"?>
--FILE--
<?php
require_once __DIR__ . "/../utils/basic.inc";

class MyReadPreference extends MongoDB\Driver\ReadPreference {}

Expand Down

0 comments on commit d9b6613

Please sign in to comment.