Fix PHP bug 66019: YYYY-MM-DDTHH is not supported #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derickr
requested changes
Apr 7, 2021
tests/c/parse_date.cpp
Outdated
| LONGS_EQUAL(1978, t->y); | ||
| LONGS_EQUAL(12, t->m); | ||
| LONGS_EQUAL(22, t->d); | ||
| LONGS_EQUAL(23, t->h); |
There was a problem hiding this comment.
Please add new tests at the end, as now the order of the original iso8601date_XX ones is now not sequential. I'd probably use timetiny24 as prefix. And you probably should also test that t->i nmd t->s are 0.
I would also add the following tests:
T9T23Z1978-12-22T91978-12-22T23Z1978-12-03T09-03(and add assert for the timezone offset and abbreviation)T09-03(and add assert for the timezone offset and abbreviation)
There was a problem hiding this comment.
I've did that now. Could you please check the assertions? I think that t->tz_abbr should be NULL, but I'm not 100% sure.
derickr
added a commit
that referenced
this pull request
Apr 7, 2022
|
I've merged this after a rebase. And will soon merge this into PHP 8.1/master. |
|
Now also merged into PHP (8.1). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.