Fixed #88: Support combining W and D in intervals #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In ISO 8601-1:2019 it is not allowed to combine weeks with any other component. And in ISO 8601-2:2019 it is allowed to combine weeks and other components, including days. |
derickr
requested changes
Aug 9, 2020
There was a problem hiding this comment.
Before I will consider this for merging, the following changes will have to be made:
- There needs to be an issue in this repository, with title "Support combining W and D in intervals". (Don't refer to PHP tickets in the head line message, they can be in the description)
- The commit messages needs to be in the form "Fixed #XX: Support combining W and D in intervals"
- A test needs to be added to
tests/c/all_tests.cppwith a new filetests/c/parse_intervals.cpp, that covers this new rule, but also a few other rules with W and D.
gharlan
changed the title
gharlan
changed the title
|
This has been merged, and is part of the 2020.02 release, which made it into PHP 8.0 too. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.php.net/bug.php?id=61366
With this PR "P1W2D" results in "9 days" instead of "2 days".