Export static package-private methods annotated with @Export as public in generated class

[jbgi]

This allows to use exclusively the generated class for all static api.
This should also addresses #41.

Also, as bonus, all static no-args methods will be exported with an additional caching of the returned value.
/cc @talios: WDYT?

[talios]

That sounds good! And we can still generate the normal methods as package-private if wanted?

I think that sounds like it should work.

[jbgi]

@talios: 0.9 has been released with this new feature. See doc at https://github.com/derive4j/derive4j/blob/master/README.md#smart-constructors-and-static-methods-export

[talios]

Looks good - will update my home project when I get home!

[talios]

In the simple case of just wanting to add simple validation ( reusing the same constructor name and arguments) derive4j will generate broken java:

  // on the generated Links.java
  public static Link full(String rel, String href, Map<String, String> properties) {
    return Link.full(rel, href, properties);
  }

I guess we should either fail gracefully rather than generated broken java, or generate the package private method as something like _full(...).

[jbgi]

Yeah you are right. Will fix this soon!

Le 11 août 2016 02:06, "Mark Derricutt" notifications@github.com a écrit :

In the simple case of just wanting to add simple validation ( reusing the
same constructor name and arguments) derive4j will generate broken java:

// on the generated Links.java
public static Link full(String rel, String href, Map<String, String> properties) {
return Link.full(rel, href, properties);
}

I guess we should either fail gracefully rather than generated broken
java, or generate the package private method as something like _full(...).

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#44 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AANi6TRbwZYBmwYEK35T7Kf1BH_RYHkhks5qemd6gaJpZM4JfWcf
.

[jbgi]

@talios I'm thinking of using the 0 suffix "convention" for package private methods. (eg java.util.Arrays#deepEquals0).