Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in case DynamoDBMapper is already provided #105

Merged
merged 1 commit into from
Dec 24, 2017

Conversation

gauravbrills
Copy link

@gauravbrills gauravbrills commented Dec 21, 2017

Fix in case dynamoDbMapper is already provided,w e dont need to check for dynamodDbMapperCofig or the assert

references issue #91

Fix in case dynamoDbMapper is already provided,w e dont need to check for dynamodDbMapperCofig or the assert
@gauravbrills gauravbrills changed the title Fix in case dynamoDbMapper is already provided Fix in case dynamoDbTemplate/DynamoDBOperations is already provided Dec 21, 2017
@gauravbrills gauravbrills changed the title Fix in case dynamoDbTemplate/DynamoDBOperations is already provided Fix in case DynamoDBMapper is already provided Dec 21, 2017
@derjust
Copy link
Owner

derjust commented Dec 22, 2017

Looking good. But as a burned kind def. want to add a unit test before merging. Will do that in the next days

@derjust
Copy link
Owner

derjust commented Dec 22, 2017

Thanks for the PR!

@gauravbrills
Copy link
Author

@derjust ya np .. was in a hurry couldn't add the test case using this custom implementation right now for my existing project .. will be great if you could merge the fix once approved in the 4.5.x branch as well .

@derjust derjust changed the base branch from master to issue_91 December 24, 2017 00:44
@derjust
Copy link
Owner

derjust commented Dec 24, 2017

Merged in branch issue_91 to add unit test.
Thanks for the PR!

@derjust derjust merged commit bd33a13 into derjust:issue_91 Dec 24, 2017
derjust added a commit that referenced this pull request Dec 24, 2017
and upated `changes.xml`
derjust added a commit that referenced this pull request Dec 24, 2017
and upated `changes.xml`
derjust added a commit that referenced this pull request Dec 24, 2017
derjust added a commit that referenced this pull request Dec 24, 2017
and upated `changes.xml`
@derjust derjust mentioned this pull request Dec 24, 2017
derjust added a commit that referenced this pull request Dec 24, 2017
@gauravbrills
Copy link
Author

HI @derjust one more thing I guess needs to be changed is getOverriddenTableName whcih will give NPE if dynamoDbconfig is not provided . Can we make the method below Public rather than introducing the new method we have for the mapper as config could be required getOverriddenTableName
DynamoDBTemplate(AmazonDynamoDB amazonDynamoDB, DynamoDBMapperConfig dynamoDBMapperConfig, DynamoDBMapper dynamoDBMapper)

@derjust
Copy link
Owner

derjust commented Dec 27, 2017 via email

@gauravbrills
Copy link
Author

gauravbrills commented Dec 27, 2017

Hi in my case I am adding a DynamoDbTemplate with a configured encryption transformer as below .. Currently using a custom DynamodBTemplate class .

return new DynamoDBTemplate(amazonDynamoDB, this.dynamoDBMapperConfig(), new DynamoDBMapper(amazonDynamoDB,
            this.dynamoDBMapperConfig(), new AttributeEncryptor(new DirectKmsMaterialProvider(awsKMS, kmsKey))));

@derjust
Copy link
Owner

derjust commented Dec 27, 2017

Created #108 to go on with the discussion there/have an issue ID to relate to

derjust added a commit that referenced this pull request Feb 16, 2018
and upated `changes.xml`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants