Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider requiring Send on GetToken.token()s error type to ease use with Failure #85

Closed
cpick opened this issue Feb 15, 2019 · 1 comment

Comments

@cpick
Copy link

cpick commented Feb 15, 2019

The (fantastic!) downstream google* crates are slightly difficult to use with the failure crate ecosystem because their google_*::Error types don't automatically implement failure::Fail because they are !Sync and !Send because their google_*::Error:: MissingToken variant returns the error from yup_oauth2::GetToken::token(): Box<dyn std::error::Error>.

If yup_oauth2::GetToken::token()s error was also Send then google_*:Error would implement failure::Fail (it still would need to be Sync, but that's easily accomplished with the failure::SyncFailure helper).

Thanks for this useful set of crates!

@dermesser
Copy link
Owner

is this something you'd be comfortable creating a pull request for? It sounds like you're more familiar with what exactly needs to be done; I don't see a reason not to merge it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants