Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add French translation #1370

Closed
wants to merge 1 commit into from
Closed

Conversation

Redblockmasteur
Copy link

Add french translation

Preview the messages on https://inlang.com/github.com/Redblockmasteur/frigate-hass-card .

@dermotduffy
Copy link
Owner

Thank you @Redblockmasteur ! Note that the strings on the dev branch are what I'd suggest we translate -- this is what I linked to on the other thread, but that's subtle I know! If it's not easy for you to move between one and the other (I seem to recall inlang doesn't support branches?), then I am (very) happy to accept this and attempt to migrate to the new dev branch strings manually -- but there'll be some gaps if I do so.

@dermotduffy dermotduffy added the enhancement New feature or request label Feb 14, 2024
@Redblockmasteur
Copy link
Author

Redblockmasteur commented Feb 14, 2024

So if i understand correctly if you merge there will be gaps. However after you merge could I just re-do the missing strings ?
Its not that inlang does not support branches, but when I cloned the repo it only cloned the main.
I'm not an expert but i know that commits to main are suboptimal to say the least. But to be honest i did not realized that i was making a pool request to main before you pointed out.
If that works better for you i could make a branch fr-translation into my repo and make an other pool request ?
image
image

@dermotduffy
Copy link
Owner

dermotduffy commented Feb 15, 2024

So if i understand correctly if you merge there will be gaps. However after you merge could I just re-do the missing strings ?

Sure! I can't comment on inlang support, but you could certainly just create a new PR on the json file and manually add in the missing strings. If you wanted to do that, here's what I'd suggest:

  • We merge this PR on main.
  • I cherrypick it across to dev and add all the missing keys as empty strings.
  • You could prepare a manual PR to fill in those empty strings on the dev branch.

Is this what you'd like to do?

@Redblockmasteur
Copy link
Author

Sorry for the late reply. Yes, please proceed with the plan we discussed earlier.

@dermotduffy dermotduffy changed the base branch from main to dev March 27, 2024 04:19
@dermotduffy dermotduffy changed the base branch from dev to main March 27, 2024 04:55
@dermotduffy
Copy link
Owner

@Redblockmasteur Thank you so much for the fr translations. I needed to do quite a bit of surgery to change the branch on this, and so many other things have changed between the branches, that I just copied the translations out of this PR and into a fresh one on the dev branch, in #1417 .

If you wanted to fill in the remaining blanks for the fr translations, I'd really appreciate it: https://github.com/dermotduffy/frigate-hass-card/blob/dev/src/localize/languages/fr.json

But either way, thank you so much for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants