Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor aspect-ratio logic #611

Merged
merged 1 commit into from
May 24, 2022
Merged

Conversation

dermotduffy
Copy link
Owner

  • Relies on the newer aspect-ratio CSS parameter that is now supported on >85% of browsers rather than old style padding hack.
  • Simplifies internal div layout.
  • Allows better experience for Chromecast out of the box.

Closes #607

@dermotduffy dermotduffy added the refactoring Refactoring label May 24, 2022
@dermotduffy dermotduffy merged commit ec30cea into release-4.0.0 May 24, 2022
@dermotduffy dermotduffy deleted the aspect-ratio-redux branch May 24, 2022 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant