Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use diffrent units for different file sizes fixes #61 #62

Merged
merged 4 commits into from Feb 22, 2017
Merged

use diffrent units for different file sizes fixes #61 #62

merged 4 commits into from Feb 22, 2017

Conversation

ducaale
Copy link
Contributor

@ducaale ducaale commented Feb 9, 2017

No description provided.

@k0pernicus
Copy link
Contributor

Hello @ducaale, thank you for this PR.
Actually, I think we can improve the code.

I think that each file has to be tagged with an enum (KB, MB, GB, etc...), and we have to derive Debug and Display for those enums to print out those.
You can maybe implement this code in a new module (filesize.rs for example), and use it in main.rs to display it...

@k0pernicus
Copy link
Contributor

Really great :-)
Thanks a lot !

@k0pernicus k0pernicus merged commit 3cb7053 into derniercri:devel Feb 22, 2017
@ducaale ducaale deleted the file_size branch February 23, 2017 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants