fix rpc payload sender real position #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Slixe. |
14 tasks
Nelbert442
added a commit
to Nelbert442/derohe
that referenced
this pull request
Feb 19, 2024
* Optimizing Inefficient Functions Usecase. * Fixes: Wallet sync issues, certificate negative serial bug, bbolt dependency. * Reproducible builds implemented. Pruning & fastsync fixes. * Several bugs fixes. Thanks to Slixe. * implement gettxkey wallet function * Out of memory error fix. * anti TX spam * Update chain_sync.go * Wallet token support * Wallet token support * arm7 doesn't start syncing * add pull request template * improve pull request template * Fix: typos (deroproject#114) * add misc, explorer, simulator in PR template (deroproject#126) * add misc, explorer, simulator in PR template * explain branch process in template * update README.md & Start.md (deroproject#127) * RingSize Sanity Check Fix by Slixe * prevent leaking path in invalid change set request, verify valid order (deroproject#130) * fix --generate-new-wallet and support --wallet-file (deroproject#136) * search TXID in all tokens history * returns SCID in which it got found * update * improve changeSet topo verification (deroproject#137) * missing variable assignation * add comments, better verification * support asset selection in integrated address (deroproject#138) * support asset selection in integrated address * show all balances available * clean balance cache on rescan, lock * better display, error * support selected SCID integrated address creation * fix rpc payload sender real position (deroproject#147) * Fix broken fastsync (deroproject#149) * fix legacy code invalid error (deroproject#151) * Delete Readme.md --------- Co-authored-by: Captain <captain@dero.io> Co-authored-by: Slixe <slixeprivate@gmail.com> Co-authored-by: 8lecramm <89603217+8lecramm@users.noreply.github.com> Co-authored-by: omahs <73983677+omahs@users.noreply.github.com> Co-authored-by: CaptainDero <34203756+CaptainDero@users.noreply.github.com>
Nelbert442
pushed a commit
to Nelbert442/derohe
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you check from which address the TX come from, you are always the sender. It's because during the transaction build part, we set in RPC Payload the wrong index. We set it of the receiver instead of the sender one.
Type of change
Please select the right one.
Which part is impacted ?
Checklist:
License
Im am contributing & releasing the code under DERO Research License (which can be found here).