Remove obsolete RequiresPhp attributes (doctrine#10631)

derrabus · Apr 14, 2023 · 2d3e89e · 2d3e89e
1 parent 727a991
commit 2d3e89e
Show file tree

Hide file tree

Showing 10 changed files with 0 additions and 28 deletions.
diff --git a/tests/Doctrine/Tests/ORM/Functional/EnumTest.php b/tests/Doctrine/Tests/ORM/Functional/EnumTest.php
@@ -23,13 +23,11 @@
 use Doctrine\Tests\Models\Enums\Unit;
 use Doctrine\Tests\OrmFunctionalTestCase;
 use PHPUnit\Framework\Attributes\DataProvider;
-use PHPUnit\Framework\Attributes\RequiresPhp;
 
 use function dirname;
 use function sprintf;
 use function uniqid;
 
-#[RequiresPhp('8.1')]
 class EnumTest extends OrmFunctionalTestCase
 {
     public function setUp(): void

diff --git a/tests/Doctrine/Tests/ORM/Functional/QueryTest.php b/tests/Doctrine/Tests/ORM/Functional/QueryTest.php
@@ -21,7 +21,6 @@
 use Doctrine\Tests\Models\Enums\UserStatus;
 use Doctrine\Tests\OrmFunctionalTestCase;
 use PHPUnit\Framework\Attributes\Group;
-use PHPUnit\Framework\Attributes\RequiresPhp;
 
 use function count;
 use function iterator_to_array;
@@ -168,7 +167,6 @@ public function testInvalidInputParameterThrowsException(): void
                   ->getSingleResult();
     }
 
-    #[RequiresPhp('8.1')]
     public function testUseStringEnumCaseAsParameter(): void
     {
         $user           = new CmsUser();
@@ -196,7 +194,6 @@ public function testUseStringEnumCaseAsParameter(): void
         self::assertSame('jane', $result[0]->username);
     }
 
-    #[RequiresPhp('8.1')]
     public function testUseIntegerEnumCaseAsParameter(): void
     {
         $user           = new CmsUser();

diff --git a/tests/Doctrine/Tests/ORM/Functional/ReadonlyPropertiesTest.php b/tests/Doctrine/Tests/ORM/Functional/ReadonlyPropertiesTest.php
@@ -11,11 +11,9 @@
 use Doctrine\Tests\Models\ReadonlyProperties\SimpleBook;
 use Doctrine\Tests\OrmFunctionalTestCase;
 use Doctrine\Tests\TestUtil;
-use PHPUnit\Framework\Attributes\RequiresPhp;
 
 use function dirname;
 
-#[RequiresPhp('8.1')]
 class ReadonlyPropertiesTest extends OrmFunctionalTestCase
 {
     protected function setUp(): void

diff --git a/tests/Doctrine/Tests/ORM/Functional/Ticket/GH10336Test.php b/tests/Doctrine/Tests/ORM/Functional/Ticket/GH10336Test.php
@@ -7,9 +7,7 @@
 use Doctrine\Tests\Models\GH10336\GH10336Entity;
 use Doctrine\Tests\Models\GH10336\GH10336Relation;
 use Doctrine\Tests\OrmFunctionalTestCase;
-use PHPUnit\Framework\Attributes\RequiresPhp;
 
-#[RequiresPhp('7.4')]
 final class GH10336Test extends OrmFunctionalTestCase
 {
     public function setUp(): void

diff --git a/tests/Doctrine/Tests/ORM/Mapping/ClassMetadataTest.php b/tests/Doctrine/Tests/ORM/Mapping/ClassMetadataTest.php
@@ -46,7 +46,6 @@
 use Doctrine\Tests\OrmTestCase;
 use DoctrineGlobalArticle;
 use PHPUnit\Framework\Attributes\Group as TestGroup;
-use PHPUnit\Framework\Attributes\RequiresPhp;
 use ReflectionClass;
 use stdClass;
 
@@ -797,7 +796,6 @@ public function testInvalidCascade(): void
         $cm->mapManyToOne(['fieldName' => 'address', 'targetEntity' => 'UnknownClass', 'cascade' => ['invalid']]);
     }
 
-    #[RequiresPhp('8.1')]
     #[TestGroup('DDC-964')]
     public function testInvalidPropertyAssociationOverrideNameException(): void
     {
@@ -810,7 +808,6 @@ public function testInvalidPropertyAssociationOverrideNameException(): void
         $cm->setAssociationOverride('invalidPropertyName', []);
     }
 
-    #[RequiresPhp('8.1')]
     #[TestGroup('DDC-964')]
     public function testInvalidPropertyAttributeOverrideNameException(): void
     {
@@ -823,7 +820,6 @@ public function testInvalidPropertyAttributeOverrideNameException(): void
         $cm->setAttributeOverride('invalidPropertyName', []);
     }
 
-    #[RequiresPhp('8.1')]
     #[TestGroup('DDC-964')]
     public function testInvalidOverrideAttributeFieldTypeException(): void
     {

diff --git a/tests/Doctrine/Tests/ORM/Mapping/MappingDriverTestCase.php b/tests/Doctrine/Tests/ORM/Mapping/MappingDriverTestCase.php
@@ -64,7 +64,6 @@
 use Doctrine\Tests\Models\Upsertable\Updatable;
 use Doctrine\Tests\OrmTestCase;
 use PHPUnit\Framework\Attributes\Depends;
-use PHPUnit\Framework\Attributes\RequiresPhp;
 use stdClass;
 
 use function assert;
@@ -585,7 +584,6 @@ public function testIdentifierRequiredShouldMentionParentClasses(): void
     }
 
     #[\PHPUnit\Framework\Attributes\Group('DDC-3579')]
-    #[RequiresPhp('8.1')]
     public function testInversedByOverrideMapping(): void
     {
         $factory       = $this->createClassMetadataFactory();
@@ -600,7 +598,6 @@ public function testInversedByOverrideMapping(): void
     }
 
     #[\PHPUnit\Framework\Attributes\Group('DDC-5934')]
-    #[RequiresPhp('8.1')]
     public function testFetchOverrideMapping(): void
     {
         // check override metadata
@@ -611,7 +608,6 @@ public function testFetchOverrideMapping(): void
     }
 
     #[\PHPUnit\Framework\Attributes\Group('DDC-964')]
-    #[RequiresPhp('8.1')]
     public function testAssociationOverridesMapping(): void
     {
         $factory       = $this->createClassMetadataFactory();
@@ -688,7 +684,6 @@ public function testAssociationOverridesMapping(): void
     }
 
     #[\PHPUnit\Framework\Attributes\Group('DDC-964')]
-    #[RequiresPhp('8.1')]
     public function testAttributeOverridesMapping(): void
     {
         $factory       = $this->createClassMetadataFactory();
@@ -952,7 +947,6 @@ public function testUpdatableColumn(): void
         self::assertNull($metadata->getFieldMapping('updatableContent')->notUpdatable);
     }
 
-    #[RequiresPhp('8.1')]
     public function testEnumType(): void
     {
         $metadata = $this->createClassMetadata(Card::class);

diff --git a/tests/Doctrine/Tests/ORM/Mapping/ReflectionReadonlyPropertyTest.php b/tests/Doctrine/Tests/ORM/Mapping/ReflectionReadonlyPropertyTest.php
@@ -9,11 +9,9 @@
 use Doctrine\Tests\Models\ReadonlyProperties\Author;
 use InvalidArgumentException;
 use LogicException;
-use PHPUnit\Framework\Attributes\RequiresPhp;
 use PHPUnit\Framework\TestCase;
 use ReflectionProperty;
 
-#[RequiresPhp('8.1')]
 class ReflectionReadonlyPropertyTest extends TestCase
 {
     public function testSecondWriteWithSameValue(): void

diff --git a/tests/Doctrine/Tests/ORM/Query/QueryTest.php b/tests/Doctrine/Tests/ORM/Query/QueryTest.php
@@ -31,7 +31,6 @@
 use Generator;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\Group;
-use PHPUnit\Framework\Attributes\RequiresPhp;
 use Psr\Cache\CacheItemInterface;
 use Psr\Cache\CacheItemPoolInterface;
 use Symfony\Component\Cache\Adapter\ArrayAdapter;
@@ -293,7 +292,6 @@ public function testProcessParameterValueNull(): void
         self::assertNull($query->processParameterValue(null));
     }
 
-    #[RequiresPhp('8.1')]
     public function testProcessParameterValueBackedEnum(): void
     {
         $query = $this->entityManager->createQuery('SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.status = :status');
@@ -302,7 +300,6 @@ public function testProcessParameterValueBackedEnum(): void
         self::assertSame([2], $query->processParameterValue([AccessLevel::User]));
     }
 
-    #[RequiresPhp('8.1')]
     public function testProcessParameterValueBackedEnumArray(): void
     {
         $query = $this->entityManager->createQuery('SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.status IN (:status)');

diff --git a/tests/Doctrine/Tests/ORM/Tools/SchemaToolTest.php b/tests/Doctrine/Tests/ORM/Tools/SchemaToolTest.php
@@ -41,7 +41,6 @@
 use Doctrine\Tests\Models\NullDefault\NullDefaultColumn;
 use Doctrine\Tests\OrmTestCase;
 use PHPUnit\Framework\Attributes\Group;
-use PHPUnit\Framework\Attributes\RequiresPhp;
 
 use function count;
 use function current;
@@ -184,7 +183,6 @@ public function testNullDefaultNotAddedToPlatformOptions(): void
             ->getPlatformOptions());
     }
 
-    #[RequiresPhp('8.1')]
     public function testEnumTypeAddedToCustomSchemaOptions(): void
     {
         $em         = $this->getTestEntityManager();

diff --git a/tests/Doctrine/Tests/ORM/Utility/IdentifierFlattenerEnumIdTest.php b/tests/Doctrine/Tests/ORM/Utility/IdentifierFlattenerEnumIdTest.php
@@ -12,13 +12,11 @@
 use Doctrine\Tests\OrmFunctionalTestCase;
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\Group;
-use PHPUnit\Framework\Attributes\RequiresPhp;
 
 /**
  * Test the IdentifierFlattener utility class
  */
 #[CoversClass(IdentifierFlattener::class)]
-#[RequiresPhp('8.1')]
 class IdentifierFlattenerEnumIdTest extends OrmFunctionalTestCase
 {
     protected function setUp(): void