-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only return email addresses in from appropriate RPCs #45
Comments
The Owner field in ObjAppData refers to e-mail, the above makes it seem like this should not be the case? In every place that ObjAppData is queried, e-mail is exchanged for display name in a separate action. |
On Mon, Jul 25, 2011 at 15:52, reedspool <
ObjAppData is at the backend. What is critical is that no RPC return email Derrell |
I'm going to write 2 functions in MVisitors.js which exchange displayName for email and vice-versa |
On Mon, Jul 25, 2011 at 16:09, reedspool <
Sounds fine. Do we need the vice-versa? I suppose similar functionality is Derrell |
Added 2 functions: MVisitors._getDisplayName(userId) and MVisitors._getVisitorId(displayName). They do what you would suppose them to do, returning displayName or email (using email interchangeably Visitor ID) These functions are now in use in the Mobile client, and could be used to simplify a bunch of code in MApps.js which does the same. |
These functions are also regression tested |
Currently, the mobile tag=all request is returning email addresses instead of (or in addition to) display names. Email addresses should never be returned except in the following two cases (I believe):
Check everyplace that references ObjVisitors to be sure that the "id" field is not returned.
The text was updated successfully, but these errors were encountered: