Only return email addresses in from appropriate RPCs

[derrell]

Currently, the mobile tag=all request is returning email addresses instead of (or in addition to) display names. Email addresses should never be returned except in the following two cases (I believe):

• the RPC used by user management, which requires specific access privs
• the whoAmI function, which returns details about the currently-logged-in user

Check everyplace that references ObjVisitors to be sure that the "id" field is not returned.

[reedspool]

The Owner field in ObjAppData refers to e-mail, the above makes it seem like this should not be the case? In every place that ObjAppData is queried, e-mail is exchanged for display name in a separate action.

[derrell]

On Mon, Jul 25, 2011 at 15:52, reedspool <
reply@reply.github.com>wrote:

The Owner field in ObjAppData refers to e-mail, the above makes it seem
like this should not be the case? In every place that ObjAppData is queried,
e-mail is exchanged for display name in a separate action.

ObjAppData is at the backend. What is critical is that no RPC return email
addresses from ObjAppData or ObjVisitors, except for the very special
(currently) two. All other cases where email addresses are in the database,
the email address should be replaced with the displayName in the RPC result.

Derrell

[reedspool]

I'm going to write 2 functions in MVisitors.js which exchange displayName for email and vice-versa

[derrell]

On Mon, Jul 25, 2011 at 16:09, reedspool <
reply@reply.github.com>wrote:

I'm going to write 2 functions in MVisitors.js which exchange displayName
for email and vice-versa

Sounds fine. Do we need the vice-versa? I suppose similar functionality is
already in use, for retrieving the ObjVisitors object given a display name,
so merging those seems reasonable.

Derrell

[reedspool]

Added 2 functions: MVisitors._getDisplayName(userId) and MVisitors._getVisitorId(displayName). They do what you would suppose them to do, returning displayName or email (using email interchangeably Visitor ID)

These functions are now in use in the Mobile client, and could be used to simplify a bunch of code in MApps.js which does the same.

[reedspool]

These functions are also regression tested