Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow whole html document parsing #1

Merged
merged 2 commits into from
Aug 26, 2014
Merged

allow whole html document parsing #1

merged 2 commits into from
Aug 26, 2014

Conversation

iantance
Copy link
Collaborator

ready for review @djreimer

I had to change "Test" to "MiniTest" in the test file to get my tests to run. (I was getting an uninitialized constant Test error.)

@iantance
Copy link
Collaborator Author

@djreimer
The build was failing and I thought that the change I made to the test file might have been the problem. I switched it back and am seeing the same "uninitialized constant Test (NameError)" error that I was getting when I ran the tests locally.

@derrickreimer
Copy link
Owner

Thanks. I made some tweaks: 1b3a708...663700d

We'll review the changes tomorrow

@derrickreimer derrickreimer merged commit 1b3a708 into derrickreimer:master Aug 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iantance @derrickreimer