Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .gbk / .gbff [.gz] files #51

Closed
tseemann opened this issue Aug 28, 2016 · 4 comments
Closed

Support .gbk / .gbff [.gz] files #51

tseemann opened this issue Aug 28, 2016 · 4 comments

Comments

@tseemann
Copy link

It would be great if --add-to-library could support .gbk/.gbff (and .gz versions thereof).

These have the taxid in taxon:NNN field in the source tag.

To make it fast you can avoid parsing the Genbank file, and just read it as follows:

https://raw.githubusercontent.com/MDU-PHL/mdu-tools/master/bin/genbank-to-kraken_fasta.pl

@dfornika
Copy link
Contributor

dfornika commented Sep 2, 2017

@tseemann

I've incorporated this suggestion into a branch of my fork:

https://github.com/dfornika/kraken/tree/add-to-library-gb

Do you have any suggestions on how this could be improved before I create a pull request?

@tseemann
Copy link
Author

tseemann commented Sep 2, 2017

@dfornika I've commented on your fork commit with some things.

@dfornika
Copy link
Contributor

@tseemann The pull request was merged so I think this issue can be closed

@tseemann
Copy link
Author

tseemann commented Sep 29, 2017

@dfornika yep thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants