This repository has been archived by the owner on Mar 21, 2018. It is now read-only.
Add compatibility with commonjs and browserify #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| // browser global | ||
| window.docReady = defineDocReady( window.eventie ); | ||
| } | ||
|
|
||
| })( this ); | ||
| })( window ); |
There was a problem hiding this comment.
I'm curious -- why not use the global this value?
There was a problem hiding this comment.
In node and browserify, the top-level this is the current module, i.e. module.exports and is {} until anything is exported. So in this case it looks for document on the current module. Obviously this won't work in node since it uses window but most other commonjs bundlers implement things this way (I think). Here's a thread with a bunch of node/browserify folks clearing it up.
There was a problem hiding this comment.
Ah! thanks for clearing that up 😀
desandro
added a commit
that referenced
this pull request
Apr 24, 2014
Add compatibility with commonjs and browserify
|
Thank you again (so much!) for the PR. I made a tweak to the package.json for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a commonjs export and package.json so this can be packaged with commonjs bundlers. Had to move
thisin the wrapper call towindowsincethisis the current module in cjs environments.If eventie#3 gets merged I can move the package json dependency to desandro/eventie