Use requirejs to Create Packaged Version #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the packaged file will work with AMD loaders.
|
I appreciate the contribution, but I feel the whole point of AMD is that it loads Modules. So either use Bower, or manually manage the dependencies. The packaged source file is designed for quick-and-straight forward in-browser use. |
desandro
added a commit
that referenced
this pull request
Nov 23, 2013
desandro
added a commit
that referenced
this pull request
Nov 23, 2013
desandro
added a commit
that referenced
this pull request
Nov 23, 2013
|
I apologize for my past ignorance. I didn't understand how the generated file with RequireJS would be the equivalent of the imagesloaded.pkgd.js. I have integrated your requirejs task into the build process. You should now be able to use imagesloaded.pkgd.js with RequireJS. |
|
Oh neat. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the packaged file will work with AMD loaders (#68).
The output differs only in that the modules are defined with a name. I tried to change as little as possible; for example, it's still using grunt-contrib-uglify to do the uglification even though grunt-contrib-requirejs can do that for you.
I took a look at the plugin you mentioned, but they're still working out some things that impact EventEmitter, so I decided to just adapt your already existing browser-list-sources task.