Added Mongo support. #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was supported in 1.8, but missing in 2.0 Supports both the mongodb\mongodb library as the (legacy) mongo extension Differenes from 1.8: - Constructor takes db and/or collection as arguments - Use `_id` field rather than custom `key` field - Expired items are ignored rather than deleted (just like Mysqli) - Using upsert rather than delete + insert - Store TTL as date bson type to allow ttl index Includes unit tests. Usage guide is added to README. Fixes desarrolla2#25
|
In version 2 I'm using different approach for adapter's constructors, i pass the entire backend object by constructor or nothing for default configuration you can see it here. I think that approach is more flexible for final user. If you want, you can to update your PR or wait for i have some time to update and then merge it. Great work by the way! |
Create default backend object is nothing is supplied
|
Ok, it was already possible to pass the backend object, I just needed to remove the 2nd argument (which was optional). I've made passing a backend optional. It will use the |
|
thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Mongo support.
This was supported in 1.8, but missing in 2.0
Supports both the mongodb\mongodb library as the (legacy) mongo extension
Differenes from 1.8:
_idfield rather than customkeyfieldIncludes unit tests.
Usage guide is added to README.
Fixes #25