Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Only check binary dependency when audio is played #22

Closed
wants to merge 1 commit into from

Conversation

user202729
Copy link

@user202729 user202729 commented Nov 7, 2019

In the current implementation, the audio is only loaded after play or output is called, so the check is done before the program make any HTTP request.

I don't have sox installed, but I have another audio player, and I want to use that, so it should not error out.

@coveralls
Copy link

coveralls commented Nov 7, 2019

Coverage Status

Coverage increased (+0.09%) to 76.406% when pulling ac518ad on user202729:lazycheckbin into fbcd022 on desbma:master.

@desbma
Copy link
Owner

desbma commented Nov 9, 2019

I have removed the bin_dep check completely instead.

Users that are trying to play sound without SoX installed will get an error anyway.

And users that only want to download the sound don't need the check.

@desbma desbma closed this Nov 9, 2019
@user202729 user202729 deleted the lazycheckbin branch November 10, 2019 02:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants