Skip to content

Commit

Permalink
Merge pull request #283 from amarandon/master
Browse files Browse the repository at this point in the history
Update deprecated imports with Django >= 1.7
  • Loading branch information
deschler committed Nov 14, 2014
2 parents bd0ea50 + 3529025 commit 9dbf3f6
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
10 changes: 7 additions & 3 deletions modeltranslation/admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,18 @@
import django
from django.contrib import admin
from django.contrib.admin.options import BaseModelAdmin, flatten_fieldsets, InlineModelAdmin
from django.contrib.contenttypes import generic
from django import forms

# Ensure that models are registered for translation before TranslationAdmin
# runs. The import is supposed to resolve a race condition between model import
# and translation registration in production (see issue #19).
if django.VERSION < (1, 7):
from django.contrib.contenttypes.generic import GenericTabularInline
from django.contrib.contenttypes.generic import GenericStackedInline
import modeltranslation.models # NOQA
else:
from django.contrib.contenttypes.admin import GenericTabularInline
from django.contrib.contenttypes.admin import GenericStackedInline
from modeltranslation import settings as mt_settings
from modeltranslation.translator import translator
from modeltranslation.utils import (
Expand Down Expand Up @@ -334,11 +338,11 @@ class TranslationStackedInline(TranslationInlineModelAdmin, admin.StackedInline)
pass


class TranslationGenericTabularInline(TranslationInlineModelAdmin, generic.GenericTabularInline):
class TranslationGenericTabularInline(TranslationInlineModelAdmin, GenericTabularInline):
pass


class TranslationGenericStackedInline(TranslationInlineModelAdmin, generic.GenericStackedInline):
class TranslationGenericStackedInline(TranslationInlineModelAdmin, GenericStackedInline):
pass


Expand Down
3 changes: 2 additions & 1 deletion modeltranslation/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,15 @@ def autodiscover():
import sys
import copy
from django.conf import settings
from django.utils.importlib import import_module
from django.utils.module_loading import module_has_submodule
from modeltranslation.translator import translator
from modeltranslation.settings import TRANSLATION_FILES, DEBUG

if django.VERSION < (1, 7):
from django.utils.importlib import import_module
mods = [(app, import_module(app)) for app in settings.INSTALLED_APPS]
else:
from importlib import import_module
from django.apps import apps
mods = [(app_config.name, app_config.module) for app_config in apps.get_app_configs()]

Expand Down

0 comments on commit 9dbf3f6

Please sign in to comment.