Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements on Token Scoping #840

Merged
merged 9 commits into from
Dec 12, 2023
Merged

Improvements on Token Scoping #840

merged 9 commits into from
Dec 12, 2023

Conversation

peterthomassen
Copy link
Member

@peterthomassen peterthomassen commented Nov 23, 2023 •
edited
Loading

  • Change policy id field to UUID
  • Add columns subname, type to policies
  • Adjust policies view for new fields
  • Include subname/type in Token default policies
  • Extend RRset serializers to honor policies
  • Update docs
  • Turn perm_manage_tokens into a virtual field (true iff token has no policies) -- rethink: no policy means "allow/create delete domains", but not necessarily manage tokens

Related: #347

@nils-wisiol nils-wisiol mentioned this pull request Nov 23, 2023
Merged
@peterthomassen peterthomassen force-pushed the 20231122_token_scoping branch 2 times, most recently from ee22229 to 1761586 Compare November 23, 2023 17:14
@peterthomassen peterthomassen changed the title feat(api): switch TokenDomainPolicy.id to UUID Improvements on Token Scoping Nov 23, 2023
@peterthomassen peterthomassen force-pushed the 20231122_token_scoping branch 2 times, most recently from 8cdb825 to 17fb787 Compare November 29, 2023 18:33
@peterthomassen peterthomassen marked this pull request as ready for review November 30, 2023 17:09
@peterthomassen peterthomassen force-pushed the 20231122_token_scoping branch 2 times, most recently from e3abd52 to 82d602e Compare December 6, 2023 15:26
@peterthomassen peterthomassen changed the base branch from main to 20231205_donate December 6, 2023 15:27
@peterthomassen peterthomassen force-pushed the 20231122_token_scoping branch 3 times, most recently from dd053d6 to 743b042 Compare December 7, 2023 15:52
nils-wisiol
nils-wisiol approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@nils-wisiol nils-wisiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

api/desecapi/models/tokens.py Outdated Show resolved Hide resolved
api/desecapi/models/tokens.py Show resolved Hide resolved
api/desecapi/tests/test_token_domain_policy.py Show resolved Hide resolved
api/desecapi/serializers/tokens.py Outdated Show resolved Hide resolved
api/desecapi/tests/test_token_domain_policy.py Outdated Show resolved Hide resolved
api/desecapi/views/tokens.py Outdated Show resolved Hide resolved
api/desecapi/permissions.py Show resolved Hide resolved
@peterthomassen peterthomassen mentioned this pull request Dec 12, 2023
Closed
@peterthomassen peterthomassen changed the base branch from 20231205_donate to main December 12, 2023 15:31
@peterthomassen peterthomassen merged commit cb34a9f into main Dec 12, 2023
5 checks passed
@peterthomassen peterthomassen deleted the 20231122_token_scoping branch December 12, 2023 15:43
@JacksonChen666 JacksonChen666 mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nils-wisiol nils-wisiol nils-wisiol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterthomassen @nils-wisiol