feat: option to disable https redirection (#23)

* fix: remove smalltalk * fix: smalltalk try 2 * Update .gitattributes * fix: removing smalltalk * fix: copy hook * feat: disable https redirection
desenvolvedor-io · Jan 5, 2023 · 8691c55 · 8691c55
1 parent 676fbd9
commit 8691c55
Show file tree

Hide file tree

Showing 21 changed files with 15 additions and 7 deletions.
diff --git a/src/api-gateways/DevStore.Bff.Checkout/Configuration/ApiConfig.cs b/src/api-gateways/DevStore.Bff.Checkout/Configuration/ApiConfig.cs
diff --git a/src/api-gateways/DevStore.Bff.Checkout/appsettings.Development.json b/src/api-gateways/DevStore.Bff.Checkout/appsettings.Development.json
@@ -22,7 +22,6 @@
       "Application": "BffCheckout"
     }
   },
-  "AllowedHosts": "*",
   "ShoppingCartUrl": "https://localhost:5411",
   "CatalogUrl": "https://localhost:5431",
   "CustomerUrl": "https://localhost:5441",

diff --git a/src/api-gateways/DevStore.Bff.Checkout/appsettings.Docker.json b/src/api-gateways/DevStore.Bff.Checkout/appsettings.Docker.json
@@ -22,7 +22,6 @@
       "Application": "BffCheckout"
     }
   },
-  "AllowedHosts": "*",
   "ShoppingCartUrl": "https://devstore-api-cart:5201",
   "CatalogUrl": "https://devstore-api-catalog:5301",
   "CustomerUrl": "https://devstore-api-customers:5401",

diff --git a/src/api-gateways/DevStore.Bff.Checkout/appsettings.Production.json b/src/api-gateways/DevStore.Bff.Checkout/appsettings.Production.json
@@ -22,7 +22,7 @@
       "Application": "BffCheckout"
     }
   },
-  "AllowedHosts": "*",
+
   "ShoppingCartUrl": "https://devstore-api-cart:5201",
   "CatalogUrl": "https://devstore-api-catalog:5301",
   "CustomerUrl": "https://devstore-api-customers:5401",

diff --git a/src/api-gateways/DevStore.Bff.Checkout/appsettings.json b/src/api-gateways/DevStore.Bff.Checkout/appsettings.json
@@ -1,5 +1,6 @@
 {
   "AllowedHosts": "*",
+  "USE_HTTPS_REDIRECTION": "true",
   "AppSettings": {
     "Issuer": "https://devstore.academy",
     "Audience": "DevStore"

diff --git a/src/services/DevStore.Billing.API/Configuration/ApiConfig.cs b/src/services/DevStore.Billing.API/Configuration/ApiConfig.cs
diff --git a/src/services/DevStore.Billing.API/appsettings.json b/src/services/DevStore.Billing.API/appsettings.json
@@ -1,5 +1,6 @@
 {
   "AllowedHosts": "*",
+  "USE_HTTPS_REDIRECTION": "true",
   "AppSettings": {
     "Issuer": "https://devstore.academy",
     "Audience": "DevStore",

diff --git a/src/services/DevStore.Catalog.API/Configuration/ApiConfig.cs b/src/services/DevStore.Catalog.API/Configuration/ApiConfig.cs
diff --git a/src/services/DevStore.Catalog.API/appsettings.json b/src/services/DevStore.Catalog.API/appsettings.json
@@ -1,5 +1,6 @@
 {
   "AllowedHosts": "*",
+  "USE_HTTPS_REDIRECTION": "true",
   "AppSettings": {
     "Issuer": "https://devstore.academy",
     "Audience": "DevStore",

diff --git a/src/services/DevStore.Customers.API/Configuration/ApiConfig.cs b/src/services/DevStore.Customers.API/Configuration/ApiConfig.cs
diff --git a/src/services/DevStore.Customers.API/appsettings.json b/src/services/DevStore.Customers.API/appsettings.json
@@ -1,5 +1,6 @@
 {
   "AllowedHosts": "*",
+  "USE_HTTPS_REDIRECTION": "true",
   "AppSettings": {
     "Issuer": "https://devstore.academy",
     "Audience": "DevStore",

diff --git a/src/services/DevStore.Identity.API/Configuration/ApiConfig.cs b/src/services/DevStore.Identity.API/Configuration/ApiConfig.cs
diff --git a/src/services/DevStore.Identity.API/appsettings.json b/src/services/DevStore.Identity.API/appsettings.json
@@ -1,5 +1,6 @@
 {
   "AllowedHosts": "*",
+  "USE_HTTPS_REDIRECTION": "true",
   "AppSettings": {
     "Issuer": "https://devstore.academy",
     "Audience": "DevStore",

diff --git a/src/services/DevStore.Orders.API/Configuration/ApiConfig.cs b/src/services/DevStore.Orders.API/Configuration/ApiConfig.cs
diff --git a/src/services/DevStore.Orders.API/appsettings.Development.json b/src/services/DevStore.Orders.API/appsettings.Development.json
@@ -22,7 +22,7 @@
       "Application": "Orders"
     }
   },
-  "AllowedHosts": "*",
+
   "ConnectionStrings": {
     "DefaultConnection": "Server=(localdb)\\mssqllocaldb;Database=DSOrders;Trusted_Connection=True;MultipleActiveResultSets=true"
   },

diff --git a/src/services/DevStore.Orders.API/appsettings.Docker.json b/src/services/DevStore.Orders.API/appsettings.Docker.json
@@ -22,7 +22,7 @@
       "Application": "Orders"
     }
   },
-  "AllowedHosts": "*",
+
   "ConnectionStrings": {
     "DefaultConnection": "Server=database-order;Database=DSOrders;MultipleActiveResultSets=true;User Id=sa;Password=MyDB@123"
   },

diff --git a/src/services/DevStore.Orders.API/appsettings.Production.json b/src/services/DevStore.Orders.API/appsettings.Production.json
@@ -22,7 +22,7 @@
       "Application": "Orders"
     }
   },
-  "AllowedHosts": "*",
+
   "ConnectionStrings": {
     "DefaultConnection": "Server=database-order;Database=DSOrders;MultipleActiveResultSets=true;User Id=sa;Password=MyDB@123"
   },

diff --git a/src/services/DevStore.Orders.API/appsettings.json b/src/services/DevStore.Orders.API/appsettings.json
@@ -1,5 +1,6 @@
 {
   "AllowedHosts": "*",
+  "USE_HTTPS_REDIRECTION": "true",
   "AppSettings": {
     "Issuer": "https://devstore.academy",
     "Audience": "DevStore",

diff --git a/src/services/DevStore.ShoppingCart.API/Configuration/ApiConfig.cs b/src/services/DevStore.ShoppingCart.API/Configuration/ApiConfig.cs
@@ -34,7 +34,11 @@ public static void UseApiConfiguration(this WebApplication app, IWebHostEnvironm
                 app.UseDeveloperExceptionPage();
             }
 
-            app.UseHttpsRedirection();
+            // Under certain scenarios, e.g minikube / linux environment / behind load balancer
+            // https redirection could lead dev's to over complicated configuration for testing purpouses
+            // In production is a good practice to keep it true
+            if (app.Configuration["USE_HTTPS_REDIRECTION"] == "true")
+                app.UseHttpsRedirection();
 
             app.UseCors("Total");
 

diff --git a/src/web/DevStore.WebApp.MVC/Configuration/WebAppConfig.cs b/src/web/DevStore.WebApp.MVC/Configuration/WebAppConfig.cs
diff --git a/src/web/DevStore.WebApp.MVC/DevStore.WebApp.MVC.csproj b/src/web/DevStore.WebApp.MVC/DevStore.WebApp.MVC.csproj