Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use date-fns library #10

Closed
souporserious opened this issue Feb 2, 2018 · 3 comments
Closed

Use date-fns library #10

souporserious opened this issue Feb 2, 2018 · 3 comments

Comments

@souporserious
Copy link

First, just wanted to say this is a wonderful little abstraction for calendars in React! 馃帀 I was curious if you would be willing to swap out similar functions with date-fns where it makes sense? I think it could reduce bundle sizes for others utilizing the date-fns library and hopefully it would keep this one a similar size since each function can be imported individually. If this sounds ok, I'd be willing to submit a PR, just let me know 馃槆
@mkartchner994
Copy link
Contributor

Yes, I would be willing to swap out the ./src/utils.js functions that make sense. PRs are definitely welcome.

Thanks for taking interest in the lib!

@mkartchner994 mkartchner994 mentioned this issue Apr 9, 2018
Closed
@arthurdenner arthurdenner mentioned this issue Apr 10, 2018
Merged
@mkartchner994
Copy link
Contributor

I think this has been done in scope of this pull request - #17.

If there was more to this you would like to see, please reopen this issue. Thanks!

@souporserious
Copy link
Author

Wonderful!!! Sorry I never got around to doing this, glad someone was able to do it though! 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@souporserious @mkartchner994