-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export functions on the utils module #14
Comments
Hello @arthurdenner! Thanks for the interest! I am hesitant to export internals of the lib. If we did that, it would make it harder in the future to change them since we wouldn't know at that point who would be relying on them. Instead, what I might like is to update those internal functions with the equivalents from the date-fns lib like This way there wouldn't be duplicate code for this logic if you wanted to implement it in your own component that is extending What are you thoughts on something like this? |
Thanks for the answer. Your hesitancy makes total sense and switch to |
Yes, a PR for this work would be great! If you are able to give me a day, I would like to add some tests to the lib that would make this refactor easier. I will ping you here when those tests have been added 馃憤 |
Nice, I'll wait for your signal then. Thanks! |
@arthurdenner I think this is ready for you now. I added some integration tests around the lib using Cypress.io - #16. Let me know if you have any questions. Thanks! |
Thanks, @mkartchner994. I'm not so familiar with publishing packages on npm, so I'm wondering, |
@arthurdenner |
Hello 馃憢
I'm building a datepicker on top of this library and wanted to know if it's possible to export the functions on the
utils
module. In my use case, I have a Today button and to make it work properly, I'm making use of the normalizeDate and isEqual functions (but copying them).Would be nice to import them directly from dayzed. What do you think about it?
Thanks in advance.
The text was updated successfully, but these errors were encountered: