Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

grumble.NewWithReadline()? #51

Closed
activey opened this issue Jun 18, 2022 · 3 comments 路 Fixed by #52
Closed

grumble.NewWithReadline()? #51

activey opened this issue Jun 18, 2022 · 3 comments 路 Fixed by #52

Comments

@activey
Copy link
Contributor

activey commented Jun 18, 2022

Hi,

Just wondering, would it be much of a hassle to implement grumble constructor with already initialized readline?

Thanks 馃槂

@skaldesh
Copy link
Member

Hi,
I guess not. Out of pure interest, could you describe the use case you need that for? :)

@activey
Copy link
Contributor Author

activey commented Jun 20, 2022

This is what I'm doing with ishell:

handleFunc := func(rl *readline.Instance) {
	shell := ishell.NewWithReadline(rl)
	// ... some more stuff
	shell.Run()
}
readline.ListenRemote("tcp", addr, cfg, handleFunc)

Why? I'm running my app in the background and I'd love to have a "remote" access to it.

@activey
Copy link
Contributor Author

activey commented Jun 26, 2022

Hey, I've created a pull request ;) #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants