Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility to run grumble with own readline instance #52

Merged
merged 3 commits into from
Jun 28, 2022

Conversation

activey
Copy link
Contributor

@activey activey commented Jun 26, 2022

closes #51

@skaldesh
Copy link
Member

Thank you, I will have a look at this over the course of this day :)

@skaldesh skaldesh self-assigned this Jun 27, 2022
Copy link
Member

@skaldesh skaldesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I need to run the sample once and understand it :)

app.go Outdated Show resolved Hide resolved
@skaldesh
Copy link
Member

I've run the sample, that is very neat with the remote stuff :)
One last thing before we merge. Can you move the readline-cli stuff into the readline folder of the samples and add a short README that tells you how to run this? Basically go run the "server" first and then run the "client".
I want our samples to be fool proof :) and I want one folder per sample, that is why I want the folders to be merged :)

Thanks for the PR!

@activey
Copy link
Contributor Author

activey commented Jun 28, 2022

Just merged the sample directories and added small readme doc :)

@skaldesh skaldesh merged commit ae966b6 into desertbit:master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grumble.NewWithReadline()?
2 participants