-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Use number of channels when calculating BAN #37
base: master
Are you sure you want to change the base?
Conversation
@boeddeker, possibly of interest -- this seems to apply to |
@boeddeker since you are the expert on this, I will defer to your opinion. |
Yes, it is missing. It was already missing, when we translated the MATLAB code. Depending on your application, you may want to think about a normalization before writing files to the disk. |
I will keep this PR open (for visibility). As pointed out by @boeddeker, it does not seem to impact ASR much. For the CHiME-7 DASR challenge, participants can choose whether or not they want to apply it in their system. |
@boeddeker & @desh2608, I just wanted to let you know, up to you whether to include it or not. |
Thanks for the heads up, in any case. |
This depends on how you dump the data to the disk. We use internally a normalization, before writing an audio file |
@popcornell could this explain some of the clipping issues you had observed, or were you able to resolve them? |
I think they will possibly still occur because there is also clipping in some arrays in CHiME-6. |
It seems the current implementation is missing a scaling by$M^{-1/2}$ when calculating BAN.$10 \log_{10} M~\text{dB}$ , which sometimes results in clipping depending on $M$ and the input signal level.
This results in a gain of
Please refer to eq. (17) in Warsitz, Blind Acoustic Beamforming Based on Generalized Eigenvalue Decomposition, 2007.