Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI/visual regression tests #105

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Conversation

krassowski
Copy link
Collaborator

@krassowski krassowski commented Nov 4, 2023

Adds minimal visual regression tests for:

The above tests will help to catch font size changes as these fixed by #103.

Adds tests for windowed notebook which is difficult to test without browser:

The runtime of the entire UI tests suite is below 2 minutes.

@mlucool mlucool self-requested a review November 6, 2023 17:29
Copy link
Member

@mlucool mlucool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both locally and on GH action I see a lot of things like:

[WebServer] [W 2023-11-04 23:51:33.682 ServerApp] wrote error: 'No such file or directory: tests-timing_outcomes-Timing-outcomes-Execution-started-at-state/Timing_outcomes.ipynb'
    Traceback (most recent call last):
      File "/opt/hostedtoolcache/Python/3.11.6/x64/lib/python3.11/site-packages/tornado/web.py", line 1786, in _execute
        result = await result
                 ^^^^^^^^^^^^
      File "/opt/hostedtoolcache/Python/3.11.6/x64/lib/python3.11/site-packages/jupyter_server/services/contents/handlers.py", line 121, in get
        model = await ensure_async(
                ^^^^^^^^^^^^^^^^^^^
      File "/opt/hostedtoolcache/Python/3.11.6/x64/lib/python3.11/site-packages/jupyter_core/utils/__init__.py", line 189, in ensure_async
        result = await obj
                 ^^^^^^^^^
      File "/opt/hostedtoolcache/Python/3.11.6/x64/lib/python3.11/site-packages/jupyter_server/services/contents/filemanager.py", line 863, in get
        raise web.HTTPError(404, "No such file or directory: %s" % path)
    tornado.web.HTTPError: HTTP 404: Not Found (No such file or directory: tests-timing_outcomes-Timing-outcomes-Execution-started-at-state/Timing_outcomes.ipynb)

I assume these are not expected. If so, can we remove this?

@krassowski
Copy link
Collaborator Author

I assume these are not expected. If so, can we remove this?

This is annoying indeed although not a problem with this PR - it also affects other other users of galata. I believe this is problem with jupyter-server and tracked in:

@krassowski krassowski merged commit 3e72068 into deshaw:master Nov 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants