Merge pull request #26 from design4pro/develop

Develop
design4pro · Nov 30, 2022 · 8ba1d19 · 8ba1d19
2 parents 0306560 + 598c5c0
commit 8ba1d19
Show file tree

Hide file tree

Showing 7 changed files with 6 additions and 9 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -24,7 +24,7 @@ jobs:
 
     steps:
       - name: Checkout [main] 🛎️
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           fetch-depth: 0
 

diff --git a/packages/nx-custom-webpack/src/builders/custom-webpack-builder.ts b/packages/nx-custom-webpack/src/builders/custom-webpack-builder.ts
@@ -27,6 +27,7 @@ export class CustomWebpackBuilder {
     root: Path,
     config: CustomWebpackBuilderConfig,
     baseWebpackConfig: Configuration,
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     buildOptions: any,
     targetOptions: TargetOptions,
     logger: logging.LoggerApi

diff --git a/packages/nx-custom-webpack/src/builders/generic-browser-builder.ts b/packages/nx-custom-webpack/src/builders/generic-browser-builder.ts
@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import {
   BuilderContext,
   BuilderHandlerFn,

diff --git a/packages/nx-release/src/generators/add/lib/normalize-options.ts b/packages/nx-release/src/generators/add/lib/normalize-options.ts
@@ -15,6 +15,7 @@ export function normalizeOptions(
   tree: Tree,
   options: AddSchema
 ): NormalizedSchema {
+  // TODO: [] move this check to generator
   const projectConfig = readProjectConfiguration(tree, options.project);
   const { build } = projectConfig.targets;
 

diff --git a/packages/nx-release/src/lib/wrap-plugin.spec.ts b/packages/nx-release/src/lib/wrap-plugin.spec.ts
@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import { mocked } from 'jest-mock';
 import { Commit } from 'semantic-release';
 import { getPathCommitHashes } from './utils/git';

diff --git a/packages/nx-vscode-extension/src/executors/build/build.spec.ts b/packages/nx-vscode-extension/src/executors/build/build.spec.ts
@@ -1,11 +1,4 @@
-import { ExecutorContext } from '@nrwl/devkit';
-import { BuildExecutorSchema } from './schema';
-
-const options: BuildExecutorSchema = {};
-
 describe('Build Executor', () => {
-  let context: ExecutorContext;
-
   it('Can run', async () => {
     // const output = await buildExecutor(options, context);
 

diff --git a/packages/nx-vscode-extension/src/executors/build/build.ts b/packages/nx-vscode-extension/src/executors/build/build.ts
@@ -8,7 +8,7 @@ export async function buildExecutor(
   options: BuildExecutorSchema,
   context: ExecutorContext
 ) {
-  const { outputPath, ..._rest } = options;
+  const { outputPath } = options;
 
   const command = `tsc -p tsconfig.app.json`.trim();