Document the Data Model for MTL #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an empty ops index page; to be filled later.
|
This should address #97. |
|
In case it's helpful for reviewers, I've dumped the sphinx output here: https://data.desi.lbl.gov/desi/users/adamyers/ADM-dm-MTL/html/ |
weaverba137
requested changes
Mar 2, 2022
There was a problem hiding this comment.
This looks fine to me. A couple of minor questions that should be addressed before merging.
For the record, we currently don't have any support for validating .ecsv files, but it's something we need to do anyway and this PR provides much stronger motivation for that.
Related: ECSV files don't have the concept of multiple HDUs, at least in versions I've looked at, so in the future we might remove the Contents section. But let's not worry about that for this PR.
weaverba137
approved these changes
Mar 3, 2022
|
Thanx for the changes. OK to merge when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents the data model for the MTL ledgers.
As part of this PR, a new
$SURVEYOPSdirectory at the root level of the data model is added to document files used by survey operations.