New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data model for the emline files #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Units need to be fixed up, but otherwise this looks fine.
...SPECTRO_REDUX/SPECPROD/tiles/GROUPTYPE/TILEID/GROUPID/emline-SPECTROGRAPH-TILEID-GROUPID.rst
Outdated
Show resolved
Hide resolved
...SPECTRO_REDUX/SPECPROD/tiles/GROUPTYPE/TILEID/GROUPID/emline-SPECTROGRAPH-TILEID-GROUPID.rst
Outdated
Show resolved
Hide resolved
...SPECTRO_REDUX/SPECPROD/tiles/GROUPTYPE/TILEID/GROUPID/emline-SPECTROGRAPH-TILEID-GROUPID.rst
Show resolved
Hide resolved
* main: (66 commits) update change log add documentation for Gaia columns resolve merge conflict add amperes to unit doc no None; K no none stars biasnight std stars fiberflat night PSF PSF fiberflat and fluxcalib sky title fiberflat fiberflat about fiber flux linking to frame resolution doc first version ...
@araichoor, I can patch up these units issues in order to get this merged quickly. However, I noticed a significant discrepancy, even after getting the units into a standard form:
The inverse variance had inconsistent units relative to |
Also, in the explanation / documentation column: |
Thanks a lot @weaverba137 for the comments/help (and @moustakas also). Please let me know if there are other things to change. |
@araichoor, thank you this looks fine. I'm going to go ahead and merge. |
This PR updates the two datamodel
*.rst
files for the emline files.The description is done in
emline-SPECTROGRAPH-TILEID-GROUPID.rst
, to which refersemline-SURVEY-PROGRAM-PIXNUM.rst
.I know the test will fail with being unhappy with the
1e-17 erg/s/cm^2
-like units; though I don't know what is the correct approach here, so I'd appreciate guidelines.Thanks!