Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data model for the emline files #128

Merged
merged 6 commits into from Jun 13, 2022
Merged

Data model for the emline files #128

merged 6 commits into from Jun 13, 2022

Conversation

araichoor
Copy link
Contributor

This PR updates the two datamodel *.rst files for the emline files.
The description is done in emline-SPECTROGRAPH-TILEID-GROUPID.rst, to which refers emline-SURVEY-PROGRAM-PIXNUM.rst.

I know the test will fail with being unhappy with the 1e-17 erg/s/cm^2-like units; though I don't know what is the correct approach here, so I'd appreciate guidelines.

Thanks!

Copy link
Member

@weaverba137 weaverba137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Units need to be fixed up, but otherwise this looks fine.

* main: (66 commits)
  update change log
  add documentation for Gaia columns
  resolve merge conflict
  add amperes to unit doc
  no None; K
  no none
  stars
  biasnight
  std stars
  fiberflat night
  PSF
  PSF
  fiberflat and fluxcalib
  sky
  title
  fiberflat
  fiberflat
  about fiber flux
  linking to frame resolution doc
  first version
  ...
@weaverba137
Copy link
Member

@araichoor, I can patch up these units issues in order to get this merged quickly. However, I noticed a significant discrepancy, even after getting the units into a standard form:

OII_FLUX          float32 1e-17 erg/s/cm^2                Fitted flux for the OII doublet
OII_FLUX_IVAR     float32 1e34 / erg^2 * s^2 * cm^4 * A^2 Inverse variance of the fitted flux for the OII doublet

The inverse variance had inconsistent units relative to OII_FLUX. There are several columns where this is the case.

@moustakas
Copy link
Member

Also, in the explanation / documentation column: OII --> [OII]

@araichoor
Copy link
Contributor Author

Thanks a lot @weaverba137 for the comments/help (and @moustakas also).
I've made the changes (correct units, remove blank lines in the notes and examples, and add brackets around OII and OIII).
A built documentation is here: https://data.desi.lbl.gov/desi/users/raichoor/tmpdir/desidatamodel_emline/20220613-v0/html/DESI_SPECTRO_REDUX/SPECPROD/tiles/GROUPTYPE/TILEID/GROUPID/emline-SPECTROGRAPH-TILEID-GROUPID.html

Please let me know if there are other things to change.

@weaverba137
Copy link
Member

@araichoor, thank you this looks fine. I'm going to go ahead and merge.

@weaverba137 weaverba137 merged commit f2830a0 into main Jun 13, 2022
@weaverba137 weaverba137 deleted the emline branch June 13, 2022 20:43
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6e3d64b on emline into e1204fe on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants