New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data model for the exposure and tile qa files #132
Conversation
The files look fine, but it appears that this assumes that #103 is already merged, when in fact it is not. Would you consider merging this branch into |
Thanks. That is correct: I've added a comment, which refers to a file which will appear in PR #103. I could:
Please let me know. |
Changing the branch can be done in GitHub itself. Let me test that. |
* fiberassign: (23 commits) add note about complete rebuild update change log improve description of FIBER_FRACFLUX_ELG_GFA Fix indents and newline to resolve Sphinx issues Add file description for exposures-SPECPROD Add descriptions for top level exposures and tiles table files fix sphinx linking errors add intermediate files in DESI_SURVEY bugfix: units update fiberassign-EXPID to fiberassign-TILEID bugfix: typo bit more descriptive index update deprecated EXPID to TILEID in file name more accurate HDU0 description bugfix: correct link to fibermap-EXPID bugfix: width formatting update fiberassign file + index in doc/DESI_SPECTRO_DATA/NIGHT/EXPID add index.rst files for the doc/DESI_TARGET/fiberassign/tiles/TILES_VERSION/TILEXX structure remove doc/DESI_TARGET/fiberassign/tile-TILEID-FIELDNUM.rst rename fiberassign-EXPID.rst to fiberassign-TILEID.rst ...
@araichoor, this is ready to merge now. Do you have any further changes? |
Thanks a lot for handling that. |
This PR addresses #114.
It modifies the data model for the
exposure-qa*fits
files and thetile-qa*fits
files, as both are very close.Comments:
exposure-qa-EXPID.rst
, and refer to those in thetile-qa-TILEID-GROUPID.rst
;fiberassign-TILEID.rst
file, which is in the not-yet-branch of the PR Datamodel for fiberassign files #103 (so the building complains the file does not exist).A built documentation is here: https://data.desi.lbl.gov/desi/users/raichoor/tmpdir/desidatamodel_exptileqa/20220615-v0/html.