Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change nanomaggies to nanomaggy in targeting files #133

Merged
merged 6 commits into from Jun 21, 2022
Merged

Conversation

geordie666
Copy link
Contributor

This PR alters uses of the unit "nanomaggies" to "nanomaggy" in targeting files (after checking that the relevant target-related files do, indeed, use "nanomaggy").

Updates have been made for two reasons:

  • Files actually include the formal unit "nanomaggy."
  • Or, files include no units, in which case "nanomaggy" is used for consistency.

@coveralls
Copy link

coveralls commented Jun 17, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling 570bdd1 on ADM-nanomag-fix into 84ef041 on main.

@geordie666
Copy link
Contributor Author

@weaverba137: This should, at least partially, address #129.

Can you tell me which directory you mean when you state to also check the DESI_SURVEY directory in #129? I only touched the DESI_TARGET directory in this PR — although I also checked that the SURVEYOPS directory contains no flux columns that would have maggy-like units.

@weaverba137
Copy link
Member

@weaverba137
Copy link
Member

DESI_SURVEY=${DESI_ROOT}/survey.

@geordie666
Copy link
Contributor Author

Thanks — I'm not an expert on the files in DESI_SURVEY, but I'll take a look as part of this PR.

@geordie666
Copy link
Contributor Author

@weaverba137: I believe I addressed all of the nanomaggies/nanomaggy discrepancies between DESI_TARGET and DESI_SURVEY. This PR is now ready for review.

Copy link
Member

@weaverba137 weaverba137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, merge when ready.

@geordie666 geordie666 merged commit 0b464b0 into main Jun 21, 2022
@geordie666 geordie666 deleted the ADM-nanomag-fix branch June 21, 2022 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants