Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at documenting maskbits #139

Merged
merged 7 commits into from Jan 31, 2023
Merged

First pass at documenting maskbits #139

merged 7 commits into from Jan 31, 2023

Conversation

forero
Copy link
Member

@forero forero commented Nov 18, 2022

First version for the maskbits documentation. It simply links to the source code on desihub where the meaning for each bit in the mask is explained.

@coveralls
Copy link

coveralls commented Nov 18, 2022

Coverage Status

Coverage: 100.0%. Remained the same when pulling f52e062 on maskbits into 890e960 on main.

Copy link
Member

@weaverba137 weaverba137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, with some minor changes. I think it is an open question though whether we want the general public digging down into the YAML files for the individual bits.

doc/bitmasks.rst Show resolved Hide resolved
doc/bitmasks.rst Outdated Show resolved Hide resolved
@weaverba137
Copy link
Member

@forero, we should revisit this in preparation for EDR. There are still some review comments to be addressed.

@forero
Copy link
Member Author

forero commented Jan 31, 2023

Hi @weaverba137. I think I have addressed the two issues that you raised. Please let me know what you think.

@weaverba137
Copy link
Member

Thank you looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants