Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update coadd and spectra descriptions and examples #143

Merged
merged 2 commits into from Mar 3, 2023
Merged

update coadd and spectra descriptions and examples #143

merged 2 commits into from Mar 3, 2023

Conversation

sbailey
Copy link
Contributor

@sbailey sbailey commented Mar 1, 2023

This PR updates the coadd and spectra files descriptions and examples, based upon what I found useful when trying to describe our formats to LSST folks.

The FIBERMAP columns still need descriptions, but I'll update that in a separate PR after addressing #137 to make it easier to sync column descriptions.

@sbailey sbailey requested a review from weaverba137 March 1, 2023 18:49
@coveralls
Copy link

coveralls commented Mar 1, 2023

Coverage Status

Coverage: 100.0%. Remained the same when pulling 0395d4b on spectra into 7568b28 on main.

Copy link
Member

@weaverba137 weaverba137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I built the Sphinx documentation myself & verified that the image appears, for example. Please update the change log for this PR before merging, but otherwise merge when ready.

@sbailey sbailey merged commit 834841e into main Mar 3, 2023
@sbailey sbailey deleted the spectra branch March 3, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants