-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to column_descriptions related to LSS columns #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks fine to me, thank you for the quick update. Please merge when ready. |
@aureliocarnero, merging #145 created some conflicts with your changes. If you like, I can resolve those. |
Yes please, if you dont mind, it would be great if you can solve it.
Cheers
El vie, 10 mar 2023, 17:49, Benjamin Alan Weaver ***@***.***>
escribió:
… @aureliocarnero <https://github.com/aureliocarnero>, merging #145
<#145> created some
conflicts with your changes. If you like, I can resolve those.
—
Reply to this email directly, view it on GitHub
<#149 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADXSAV76PUFUCQNMO7VSGNLW3NSTJANCNFSM6AAAAAAVWSKEKM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
OK, conflicts are resolved. Please take a final look at the changes to confirm that everything still looks OK. |
I confirm everything is correct. You can go with the changes. Cheers
El vie, 10 mar 2023, 18:13, Benjamin Alan Weaver ***@***.***>
escribió:
… OK, conflicts are resolved. Please take a final look at the changes to
confirm that everything still looks OK.
—
Reply to this email directly, view it on GitHub
<#149 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADXSAV3OUPLNYPGY4IEM3SLW3NVK7ANCNFSM6AAAAAAVWSKEKM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will resolve issues 146 and 148, related to some inconsistencies for some LSS columns.
The exact changes applied to column_descriptions.csv are:
LRG_MASK set to uint8
O2C set to float64
LOCATION_ASSIGNED set to bool
IS_QSO_MGII set to bool
FLUX_{g,r,z,w1,w2}_DERED set to float32