Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to column_descriptions related to LSS columns #149

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

aureliocarnero
Copy link
Contributor

This pull request will resolve issues 146 and 148, related to some inconsistencies for some LSS columns.

The exact changes applied to column_descriptions.csv are:

  • Remove the following columns: sort, elg_mask, Z_not4clus, LOCFULL
  • Capitalization of: lrg_mask, o2c, flux_{g,r,z,w1,w2}_dered
  • Change/define types:
    LRG_MASK set to uint8
    O2C set to float64
    LOCATION_ASSIGNED set to bool
    IS_QSO_MGII set to bool
    FLUX_{g,r,z,w1,w2}_DERED set to float32
  • Units of FLUX_{g,r,z,w1,w2}_DERED set to nanomaggy
  • Description of LOCATION_ASSIGNED: True/False for assigned/unassigned for the target in question

@coveralls
Copy link

coveralls commented Mar 10, 2023

Coverage Status

Coverage: 100.0%. Remained the same when pulling d476781 on correct_lss_columns_descriptor into 8f99ae8 on main.

@weaverba137
Copy link
Member

This looks fine to me, thank you for the quick update. Please merge when ready.

@weaverba137
Copy link
Member

@aureliocarnero, merging #145 created some conflicts with your changes. If you like, I can resolve those.

@aureliocarnero
Copy link
Contributor Author

aureliocarnero commented Mar 10, 2023 via email

@weaverba137
Copy link
Member

OK, conflicts are resolved. Please take a final look at the changes to confirm that everything still looks OK.

@aureliocarnero
Copy link
Contributor Author

aureliocarnero commented Mar 10, 2023 via email

@weaverba137
Copy link
Member

Good, thank you!

@weaverba137 weaverba137 merged commit 6980074 into main Mar 10, 2023
@weaverba137 weaverba137 deleted the correct_lss_columns_descriptor branch March 10, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants