RA/DEC in Barycentric ICRS, not J2000 #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the tests for the column update code were relying on values in the csv file that need to be updated in the tests themselves. If you can fix those, I don't see any reason not to merge as soon as tests pass. PS, while you're looking at desidatamodel, #157 just needs a review before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes RA/DEC references to J2000, replacing them with more correct descriptions of barycentric ICRS. I also updated the standard column description file so that future updates will use the more correct description. I didn't change pre-existing descriptions that just said "Right Ascension" without mentioning J2000, since they are correct even if they are less complete than they could be (and we've got a lot of other more important EDR tasks on our plate).
fixes #147