Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update redrock/zcat files #161

Merged
merged 2 commits into from May 12, 2023
Merged

update redrock/zcat files #161

merged 2 commits into from May 12, 2023

Conversation

sbailey
Copy link
Contributor

@sbailey sbailey commented May 11, 2023

This PR updates the related set of redrock/zcatalog files:

  • Individual redrock tile and healpix files
  • Stacks of those files in ztile and zpix files
  • Stack of those files in zall-tilecumulative and zall-pix files

It also makes a code update so that update_column_descriptions will treat "label for field ..." the same as a blank description.

Fixes #107 and fixes #115.

@sbailey sbailey requested a review from weaverba137 May 11, 2023 22:50
@coveralls
Copy link

coveralls commented May 11, 2023 •
edited

Coverage Status

Coverage: 100.0%. Remained the same when pulling 64f1e40 on zcat into cafae13 on main.

weaverba137
weaverba137 approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@weaverba137 weaverba137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor RST fussiness request. Merge when ready.

doc/DESI_SPECTRO_REDUX/SPECPROD/zcatalog/ztile-SURVEY-PROGRAM-GROUPTYPE.rst Outdated Show resolved Hide resolved
@sbailey sbailey merged commit 5c358aa into main May 12, 2023
20 checks passed
@sbailey sbailey deleted the zcat branch May 12, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverba137 weaverba137 weaverba137 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data model for "individual" redshift catalog files Data model for redshift catalog roll-up files
3 participants
@sbailey @coveralls @weaverba137